Thanks to visit codestin.com
Credit goes to Github.com

Skip to content

MWPW-184874 Link checker remains spinning#5246

Merged
milo-pr-merge[bot] merged 2 commits intostagefrom
LinkCheckerFix
Jan 21, 2026
Merged

MWPW-184874 Link checker remains spinning#5246
milo-pr-merge[bot] merged 2 commits intostagefrom
LinkCheckerFix

Conversation

@skholkhojaev
Copy link
Contributor

@skholkhojaev skholkhojaev commented Dec 11, 2025 •
edited by github-actions bot
Loading

Description

the problem was in the waitForFooter() function… originally before we decided to call preflight in delayed.js in order to be able to check the links in the footer we had to wait until the globalFooter would be loaded, hence we needed the waitForFooter(). thats why the preflight was waiting endlessly for the FooterReady callback ( which was being dispatched before preflight even started listening ) hence the endless loop.

I have also cahnged the loadvideo function to now resolve if a video has no 'data-video-source' and 'soruce' tag
this is because in the https://main--cc--adobecom.aem.page/products/illustrator page if you open the preflight panel the Link and the Assets will never load and have an infinite spinning loading icon.

Resolves: MWPW-184874

Test URLs:

@skholkhojaev skholkhojaev requested a review from a team as a code owner December 11, 2025 10:05
@skholkhojaev skholkhojaev changed the title MWPW-184874 Link checker remains fix MWPW-184874 Link checker remains spinning Dec 11, 2025
@skholkhojaev skholkhojaev requested review from mokimo, overmyheadandbody and robert-bogos and removed request for a team December 11, 2025 11:26
mokimo
mokimo approved these changes Dec 11, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2025

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2025

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added the Stale label Dec 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 27, 2025

Closing this PR due to inactivity.

@github-actions github-actions bot closed this Dec 27, 2025
@skholkhojaev skholkhojaev reopened this Jan 8, 2026
@github-actions github-actions bot removed the Stale label Jan 9, 2026
@SilviuLCF SilviuLCF self-requested a review January 13, 2026 12:07
SilviuLCF
SilviuLCF approved these changes Jan 13, 2026
View reviewed changes
Copy link

@SilviuLCF SilviuLCF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified , testing details
https://jira.corp.adobe.com/browse/MWPW-184874

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Jan 13, 2026

Skipped merging 5246: MWPW-184874 Link checker remains spinning due to failing or running checks

1 similar comment
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Jan 14, 2026

Skipped merging 5246: MWPW-184874 Link checker remains spinning due to failing or running checks

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Jan 15, 2026

Skipped merging 5246: MWPW-184874 Link checker remains spinning due to failing or running checks

4 similar comments
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Jan 16, 2026

Skipped merging 5246: MWPW-184874 Link checker remains spinning due to failing or running checks

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Jan 17, 2026

Skipped merging 5246: MWPW-184874 Link checker remains spinning due to failing or running checks

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Jan 18, 2026

Skipped merging 5246: MWPW-184874 Link checker remains spinning due to failing or running checks

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Jan 19, 2026

Skipped merging 5246: MWPW-184874 Link checker remains spinning due to failing or running checks

@skholkhojaev
changed the waitForFooter function to now look if the footer is Ready…
6ba6480 
… or the blockStatus is loaded

loadVideo now resolves if the tag does not have data-video-source and source

implemented the review

fixed linting errors
@skholkhojaev
rebased from stage
229cb5d
@milo-pr-merge milo-pr-merge bot merged commit e8685da into stage Jan 21, 2026
14 checks passed
@milo-pr-merge milo-pr-merge bot deleted the LinkCheckerFix branch January 21, 2026 09:21
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jan 21, 2026
Merged
suhjainadobe pushed a commit to suhjainadobe/milo that referenced this pull request Jan 27, 2026
@skholkhojaev
MWPW-184874 Link checker remains spinning (adobecom#5246)
9d99445 
* changed the waitForFooter function to now look if the footer is Ready or the blockStatus is loaded

loadVideo now resolves if the tag does not have data-video-source and source

implemented the review

fixed linting errors

* rebased from stage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SilviuLCF SilviuLCF SilviuLCF approved these changes

@mokimo mokimo mokimo approved these changes

@robert-bogos robert-bogos robert-bogos approved these changes

@overmyheadandbody overmyheadandbody Awaiting requested review from overmyheadandbody

Assignees

No one assigned

Labels

Ready for Stage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@skholkhojaev @SilviuLCF @mokimo @robert-bogos