Thanks to visit codestin.com
Credit goes to Github.com

Skip to content

Conversation

@vhargrave
Copy link
Contributor

@vhargrave vhargrave commented Dec 11, 2025

common base root URLs
Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html

Milo:

Before: https://main--milo--adobecom.aem.live/?martech=off
After: https://stage--milo--adobecom.aem.live/?martech=off

GNav Test URLs

Gnav + Footer + Region Picker modal:

Thin Gnav + ThinFooter + Region Picker dropup:

Localnav + Promo:

Sticky Branch Banner:

Inline Branch Banner:

Blog

RTL Locale

* Lingo locale config base

* Move to the new Lingo locale definition

* MWPW-181893 minor code refactoring

* MWPW-181893 remove comment

* MWPW-181893 fix unit test

* MWPW-181893 fix nala test language selector & make getLanguage more robust

* MWPW-181893 wait for placeholders to resolve

* MWPW-181893 make code more readable (PR feedback)

* MWPW-179494 start adding query-index

* MWPW-179494 start loading query indexes

* MWPW-179494 ensure only one call for query indexes

* MWPW-179494 add async localize Link method

* MWPW-179494 add base implementation to localize links

* MWPW-179494 refactor slightly

* MWPW-179494 minor code fixes and add elements for testing

* MWPW-179494 update decorateLinks to now be decorateLinksAsync and add minor fixes

* MWPW-179494 use localizeLinkAsync

* MWPW-179494 fix unit tests

* MWPW-179494 refactor code

* MWPW-179494 increase unit test time and fix carousel & tabs

* MWPW-179494 stop sections appearing before being ready - fix cls

* MWPW-179494 fix hanging tests

* MWPW-179494 updates from PR feedback

* MWPW-179494 delay localization of footer & header meta

* MWPW-179494 remove space

* MWPW-179494 remove debugger;

* MWPW-179494 add unit tests for link localization

* MWPW-179494 remove lana cleanup

* MWPW-179494 feedback Rares & add line to prevent regional fragment async

* MWPW-179494 remove test helpers

* MWPW-179494 update with feedback PR review

* MWPW-179494 add metadata and url param switch for lingo

* MWPW-179494 update unit tests

* use langFirst metadata

---------

Co-authored-by: Rares Munteanu <[email protected]>
@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Dec 11, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@github-actions
Copy link
Contributor

SNOW Change Request Transaction ID: 0000019affb68571-5061dd

@vhargrave vhargrave added the do not merge PR should not be merged yet label Dec 11, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-console> reported by reviewdog 🐶
Unexpected console statement.

console.log('DEFAULT');

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-console> reported by reviewdog 🐶
Unexpected console statement.

console.log('Could not load additonal Form Template options from FaaS.', err);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-console> reported by reviewdog 🐶
Unexpected console statement.

console.log('Error loading script: ', error);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-console> reported by reviewdog 🐶
Unexpected console statement.

console.log(`Could not create footer: ${error}`);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-console> reported by reviewdog 🐶
Unexpected console statement.

console.log('Could not create footer.');

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-console> reported by reviewdog 🐶
Unexpected console statement.

console.warn(`Failed to load from MAS repository, falling back to Milo deps: ${error.message}`);

Copy link
Contributor

@skumar09 skumar09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking the merge

@mokimo mokimo deployed to milo_pr_merge December 25, 2025 09:20 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge PR should not be merged yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants