-
Notifications
You must be signed in to change notification settings - Fork 212
[Release] Stage to Main #5251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Release] Stage to Main #5251
Conversation
* Lingo locale config base * Move to the new Lingo locale definition * MWPW-181893 minor code refactoring * MWPW-181893 remove comment * MWPW-181893 fix unit test * MWPW-181893 fix nala test language selector & make getLanguage more robust * MWPW-181893 wait for placeholders to resolve * MWPW-181893 make code more readable (PR feedback) * MWPW-179494 start adding query-index * MWPW-179494 start loading query indexes * MWPW-179494 ensure only one call for query indexes * MWPW-179494 add async localize Link method * MWPW-179494 add base implementation to localize links * MWPW-179494 refactor slightly * MWPW-179494 minor code fixes and add elements for testing * MWPW-179494 update decorateLinks to now be decorateLinksAsync and add minor fixes * MWPW-179494 use localizeLinkAsync * MWPW-179494 fix unit tests * MWPW-179494 refactor code * MWPW-179494 increase unit test time and fix carousel & tabs * MWPW-179494 stop sections appearing before being ready - fix cls * MWPW-179494 fix hanging tests * MWPW-179494 updates from PR feedback * MWPW-179494 delay localization of footer & header meta * MWPW-179494 remove space * MWPW-179494 remove debugger; * MWPW-179494 add unit tests for link localization * MWPW-179494 remove lana cleanup * MWPW-179494 feedback Rares & add line to prevent regional fragment async * MWPW-179494 remove test helpers * MWPW-179494 update with feedback PR review * MWPW-179494 add metadata and url param switch for lingo * MWPW-179494 update unit tests * use langFirst metadata --------- Co-authored-by: Rares Munteanu <[email protected]>
|
SNOW Change Request Transaction ID: 0000019affb68571-5061dd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected console statement.
milo/libs/blocks/faas-config/faas-config.js
Line 100 in 62cab01
| console.log('DEFAULT'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected console statement.
milo/libs/blocks/faas-config/faas-config.js
Line 441 in 62cab01
| console.log('Could not load additonal Form Template options from FaaS.', err); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected console statement.
milo/libs/blocks/faas-config/faas-config.js
Line 528 in 62cab01
| console.log('Error loading script: ', error); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected console statement.
milo/libs/blocks/footer/footer.js
Line 349 in 62cab01
| console.log(`Could not create footer: ${error}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected console statement.
milo/libs/blocks/footer/footer.js
Line 359 in 62cab01
| console.log('Could not create footer.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected console statement.
milo/libs/blocks/merch/merch.js
Line 486 in 62cab01
| console.warn(`Failed to load from MAS repository, falling back to Milo deps: ${error.message}`); |
skumar09
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking the merge
common base root URLs
Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html
Milo:
Before: https://main--milo--adobecom.aem.live/?martech=off
After: https://stage--milo--adobecom.aem.live/?martech=off
GNav Test URLs
Gnav + Footer + Region Picker modal:
Thin Gnav + ThinFooter + Region Picker dropup:
Localnav + Promo:
Sticky Branch Banner:
Inline Branch Banner:
Blog
RTL Locale