remove manual loopPoolPtr reset in TcpServer::stop() #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes a critical issue where TcpServer might crash or hang during the shutdown process. The root cause is the premature destruction of the EventLoopPool before all cleanup tasks are completed.
Fix: Ensure EventLoopPool lifetime covers connection cleanup in TcpServer
hwc0919
reviewed
Jan 26, 2026
Collaborator
hwc0919
left a comment
There was a problem hiding this comment.
What about this:
auto loopPoolPtr = loopPoolPtr_.release();
loopPoolPtr_ = nullptr;
In this case the pool will stop when TcpServer::stop() returns (if the pool was created by TcpServer). Otherwise the pool will keep running until TcpServer instance destructs.
Could you try it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a issue where TcpServer might crash or hang during the shutdown process. The root cause is the premature destruction of the EventLoopPool before all cleanup tasks are completed.