AAP-49133: Only consider first entry in comma-separated remote host headers for provisioning callback#16284
Open
chrismeyersfsu wants to merge 1 commit intoansible:develfrom
Open
AAP-49133: Only consider first entry in comma-separated remote host headers for provisioning callback#16284chrismeyersfsu wants to merge 1 commit intoansible:develfrom
chrismeyersfsu wants to merge 1 commit intoansible:develfrom
Conversation
📝 WalkthroughWalkthroughReplaced host extraction in callback matching to use a new utility that returns only the first comma-separated entry from configured headers; added that utility and updated views to call it. Added unit and functional tests covering first-entry semantics and proxy header variations. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
* When the remote host header values contains a comma separated list, only consider the first entry. Previously we considered every item in the list.
beeb5c9 to
a5138f1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Changes the provisioning callback host matching logic to only consider the first entry in comma-separated header values (e.g.,
X-Forwarded-For: client, proxy1, proxy2), rather than all entries.Previously,
get_remote_hostsfromdjango-ansible-basewould return every value in comma-separated headers, meaning intermediate proxy addresses could incorrectly match inventory hosts. This replaces that with a newget_first_remote_host_from_headersutility inawx.main.utils.proxythat only extracts the first (original client) entry from each header.ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
Adds unit tests for the new
get_first_remote_host_from_headersandis_proxy_in_headersutility functions, and functional tests validating that only the first entry in comma-separated callback headers is matched against inventory hosts.