[DRAFT] feat(ONYX-1977): Add Artwork and Artist images to the signup modal #16483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#6040 Bundle Size — 9.52MiB (+1.97%).d26250e(current) vs d8a33c5 main#6037(baseline) Warning Bundle contains 34 duplicate packages – View duplicate packages Warning Bundle introduced 2 new packages: @swc/helpers, regenerator-runtime – View changed packages Bundle metrics
Bundle size by type
Bundle analysis report Branch araujobarret/feat/signup-modal-a... Project dashboard Generated by RelativeCI Documentation Report issue |
* add prefetching for images * chore: refactor * Update src/Components/AuthDialog/AuthDialogContext.tsx Co-authored-by: Copilot <[email protected]> * chore: address copilot review comment * Update src/Components/AuthDialog/AuthDialogContext.tsx Co-authored-by: Copilot <[email protected]> * chore: check if the image was already prefethced * chore: address review comments * feat: prefetch correct size of the image * chore: do not prefetch on mobile web * chore: address review comments --------- Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of this PR is: Feat
This PR solves ONYX-1977
Description
Adapts the places we call the hook to open the modal by receiving an image URL prop and using it to display the Artwork.
Most of the changes were trivial, adding the field to the GraphQL and passing it to the auth hook call. A few (create alert and save artwork) required some stretch to receive the image URL in its context.
Main commits:
150bd60 most of the changes to add image urls
834e074 changes to the create alert flow
fa443ab changes to the save artwork flow
PS: There are many changes because of graphql auto-generated types, don't be intimidated by the PR's size