feat(DIAM-76): add no index to artist pages without content #16553
Conversation
| genes(first: 0) { | ||
| totalCount | ||
| } | ||
| } |
There was a problem hiding this comment.
I would be very wary here and only proceed if we really understand the perf characteristics of this query. Part of what makes the artist page fast is that we both defer some of the query onto the client, and lazy load some of it once we scroll into view. Which does mean we can't know about the state of the page really until we load the client. This moves all that logic upfront to the server which would increase the TTFB quite a bit.
There was a problem hiding this comment.
Got it. Should I simplify and just check for artworks and bio?
There was a problem hiding this comment.
One approach would be to just benchmark this to see what kind of impact it really has. Set up some kind of script that pings a bunch of different artist routes, then add each piece of the fragment here and see how it changes the response time. You'd want to be ensure they are uncached.
My intuition says that the benefit of this feature isn't going to be worth the effort/query cost. We moved away from the server-side rendered pieces for a reason.
The type of this PR is: FEAT
This PR solves DIAM-76
Description
This ticket was initially an investigatory ticket to see why some artist pages weren't in the sitemap. I didn't see Damon's comments on the ticket so I ended up investigating the issue again and came to the same conclusion (pages aren't being added to the sitemap because we only check for presence of artworks and bio, and pages may have other content like articles and auction results. In this PR I implemented Paul's suggestion (only noindex if there are absolutely no UI modules on the page and then monitor things). Expanding the criteria for sitemap inclusion is also an option we can consider, but I was wary of making the sitemap too large.