Thanks to visit codestin.com
Credit goes to Github.com

Skip to content

fix(core): custom lsp configuration#9049

Open
ematipico wants to merge 1 commit intomainfrom
fix/custom-configuration-loading
Open

fix(core): custom lsp configuration#9049
ematipico wants to merge 1 commit intomainfrom
fix/custom-configuration-loading

Conversation

@ematipico
Copy link
Member

@ematipico ematipico commented Feb 13, 2026 •
edited
Loading

Summary

Closes #7138

There were two bugs:

  • The way we loaded the configuration from the text_document event. Literally, we weren't checking for configuration_path.
  • The second, we were bailing in case we couldn't find an ignore file, missing the chance to save the root settings inside the Projects hashmap

Test Plan

Heavy manual testing using the user's reproduction

Docs

N/A bug fix

@changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2026

🦋 Changeset detected

Latest commit: cdc1abf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@biomejs/biome Patch
@biomejs/cli-win32-x64 Patch
@biomejs/cli-win32-arm64 Patch
@biomejs/cli-darwin-x64 Patch
@biomejs/cli-darwin-arm64 Patch
@biomejs/cli-linux-x64 Patch
@biomejs/cli-linux-arm64 Patch
@biomejs/cli-linux-x64-musl Patch
@biomejs/cli-linux-arm64-musl Patch
@biomejs/wasm-web Patch
@biomejs/wasm-bundler Patch
@biomejs/wasm-nodejs Patch
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ematipico ematipico requested review from a team February 13, 2026 10:39
@github-actions github-actions bot added A-Project Area: project A-LSP Area: language server protocol labels Feb 13, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 13, 2026

Walkthrough

The pull request fixes an issue where the Biome language server fails to honour the configurationPath setting from the VS Code extension. It introduces a precedence mechanism to prioritise user-provided configuration paths (via extension settings) before reverting to the original path-based resolution logic. Changes include a changelog entry, a new helper method in the session, conditional loading logic in the text document handler, and adjustments to workspace server configuration handling.

Possibly related PRs

Suggested labels

A-LSP, A-Project

Suggested reviewers

  • dyc3
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix(core): custom lsp configuration' accurately summarises the main change—fixing LSP configuration loading to respect custom configuration paths.
Description check ✅ Passed The description clearly explains the two bugs fixed and links to issue #7138, relating directly to the changeset.
Linked Issues check ✅ Passed The PR addresses both objectives from issue #7138: checking configuration_path during text_document event handling and preventing early exit when ignore files are missing.
Out of Scope Changes check ✅ Passed All changes directly address the configuration loading bugs; the debug log formatting change in workspace.rs is a minor formatting improvement within scope.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/custom-configuration-loading

No actionable comments were generated in the recent review. 🎉

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-LSP Area: language server protocol A-Project Area: project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛 Biome VS Code Extension Configuration Issue when format on save

1 participant

@ematipico