Thanks to visit codestin.com
Credit goes to Github.com

Skip to content

Fix test combine FOVs #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ziw-liu merged 5 commits into from
Mar 21, 2025
Merged

Fix test combine FOVs #283

ziw-liu merged 5 commits into from
Mar 21, 2025

Conversation

@ziw-liu
Copy link
Contributor

@ziw-liu ziw-liu commented Mar 19, 2025 •
edited
Loading

Fix #255.

The original test fails due to an ome-zarr-py bug: ome/ome-zarr-py#248 (comment)

@ziw-liu ziw-liu added NGFF OME-NGFF (OME-Zarr format) CI Continuous integration labels Mar 19, 2025
@ziw-liu ziw-liu requested a review from ieivanov March 19, 2025 23:06
@ziw-liu ziw-liu marked this pull request as ready for review March 20, 2025 00:07
@ziw-liu ziw-liu marked this pull request as draft March 20, 2025 00:21
@ziw-liu ziw-liu marked this pull request as ready for review March 20, 2025 01:09
@ziw-liu ziw-liu added this to the 0.2.0 milestone Mar 20, 2025
@ieivanov
Copy link
Contributor

ieivanov commented Mar 20, 2025

Thanks! This test no longer uses ome_zarr.reader - is that OK? I think that was the only test that used that external reader, which I thought was a way to ensure that iohub zarr stores can be read by the "standard" reader. Do we have (or need) and independent test for that?

@ziw-liu
Copy link
Contributor Author

ziw-liu commented Mar 20, 2025

Added a separate test that doesn't trigger the bug.

ieivanov
ieivanov approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@ieivanov ieivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ziw-liu ziw-liu merged commit 52b313a into main Mar 21, 2025
7 checks passed
@ziw-liu ziw-liu deleted the fix-test-combine-fovs branch March 21, 2025 20:40
@ziw-liu ziw-liu mentioned this pull request Apr 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ieivanov ieivanov ieivanov approved these changes

@talonchandler talonchandler Awaiting requested review from talonchandler

@edyoshikun edyoshikun Awaiting requested review from edyoshikun

Assignees

No one assigned

Labels

CI Continuous integration NGFF OME-NGFF (OME-Zarr format)

Projects

None yet

Milestone

0.2.0

Development

Successfully merging this pull request may close these issues.

test_combine_fovs_to_hcs fails

3 participants

@ziw-liu @ieivanov