Add support for sarif output files. #1617
Open
+119
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrosdahl
reviewed
Aug 11, 2025
Only msvc was tested, worked for simply example.
d13dc2d to
a13c1d4
Compare
Contributor
Author
jrosdahl
reviewed
Sep 4, 2025
Comment on lines
+1500
to
+1501
| args_info.output_sarif = args_info.input_file; | ||
| args_info.output_sarif.append(".sarif"); |
Member
There was a problem hiding this comment.
Apparently, this is not how GCC decides where to write sarif data. See my suggested update of the test case in a comment below.
| using namespace std::string_view_literals; | ||
| auto param = std::string_view(arg).substr("-fdiagnostics-format="sv.size()); | ||
| if (param == "sarif-file") { | ||
| args_info.generating_sarif = true; |
Member
There was a problem hiding this comment.
Since the sarif file includes CWD we should set state.hash_actual_cwd = true here.
Co-authored-by: Joel Rosdahl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only msvc was tested, worked for simply example.
Fixes #1614 and #1466.
Open questions that I have not looked at:
Should we "rewrite" the arguments like done for other options?