Make loadable on clisp without threads#197
Open
vibs29 wants to merge 3 commits intocl-plus-ssl:masterfrom
Open
Make loadable on clisp without threads#197vibs29 wants to merge 3 commits intocl-plus-ssl:masterfrom
vibs29 wants to merge 3 commits intocl-plus-ssl:masterfrom
Conversation
Bordeaux-threads used to be a portability layer over threaded and non-threaded Lisps such that libraries (such as cl+ssl) could write (make-lock) and (acquire-lock) without read conditionals to check whether the Lisp implementation supported threads at all. Bordeaux-threads provided correct no-op definitions for such functions on non-threaded Lisps. At some point after bordeaux-threads-0.8.8 it decided to not load into non-threaded Lisps any more by design. That meant that users of e.g. clisp without threads could no longer even use Drakma to fetch a web page, (recalling that the web has moved from http to https). All libraries built on bordeaux-threads, assuming they want to continue supporting non-threaded Lisps, must therefore introduce conditionals around various bordeaux-threads function calls. This commit makes that change to cl+ssl so that cl+ssl loads and works again on non-threaded clisp even with the newest bordeaux-threads. Aside: clisp can be built with thread support. However that is not just beta, it is known to have race conditions because some data structures have not yet been made thread-safe. So the only correct variant of clisp is one built without thread support, which is the default build everywhere I've seen.
Member
|
Somebody could create a portability library with API equal to bordeaux-threads and implementing the no-ops for non-threaded lisps, and with fall back to real bordeaux-threads on threaded lisps :) |
7f45344 to
d3e3cc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bordeaux-threads used to be a portability layer over threaded and non-threaded Lisps such that libraries (such as cl+ssl) could write (make-lock) and (acquire-lock) without read conditionals to check whether the Lisp implementation supported threads at all. Bordeaux-threads provided correct no-op definitions for such functions on non-threaded Lisps. At some point after bordeaux-threads-0.8.8 it decided to not load into non-threaded Lisps any more by design.
That meant that users of e.g. clisp without threads could no longer even use Drakma to fetch a web page, (recalling that the web has moved from http to https).
All libraries built on bordeaux-threads, assuming they want to continue supporting non-threaded Lisps, must therefore introduce conditionals around various bordeaux-threads function calls.
This commit makes that change to cl+ssl so that cl+ssl loads and works again on non-threaded clisp even with the newest bordeaux-threads.
Aside: clisp can be built with thread support. However that is not just beta, it is known to have race conditions because some data structures have not yet been made thread-safe. So the only correct variant of clisp is one built without thread support, which is the default build everywhere I've seen.