-
Notifications
You must be signed in to change notification settings - Fork 960
Add heading prop support and improve mobile SDK scoping #2992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
manovotny
wants to merge
23
commits into
main
Choose a base branch
from
manovotny/manifest-heading-prop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new ManifestHeading type to support items with `heading: true` that act as section headers without an href. Also fixes SDK filtering errors by removing android/ios conditionals from pages under the Guides section which doesn't include those SDKs. Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Fix copy-paste error: Android User Management now correctly links to /docs/reference/android/user instead of iOS path - Add frontmatter SDK to SDK computation for manifest items to better reflect document capabilities - Clarify SDK scoping precedence: explicit group SDK restrictions are now preserved even if children support more SDKs - Update comments to explain SDK logic for cases like Mobile Navigation section
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Add iOS reference docs from mike/ios-v1-docs branch: auth, clerk, configuration, installation, organizations, user - Add Android auth.mdx from sam/android-v1-auth-reference branch - Create docs/reference/android/todo.mdx placeholder for missing Android docs - Update manifest to point missing Android docs to the todo placeholder
- Add iOS quickstart guide - Update 12 custom flow guides with iOS support - Update reference view docs (auth-view, user-button, user-profile-view) - Update iOS overview and remove deprecated get-token.mdx - Update manifest: remove iOS getToken entry, point Android auth to todo placeholder
- Add installation.mdx with Gradle setup instructions - Add configuration.mdx with Clerk.initialize() pattern - Add clerk.mdx with reactive state flows (Clerk.userFlow, Clerk.isInitialized) - Add user.mdx for user management methods - Add organizations.mdx for organization management - Update auth.mdx to use Clerk.auth (uppercase) consistently - Update manifest.json to point to new Android reference pages Co-Authored-By: Claude Opus 4.5 <[email protected]>
Co-Authored-By: Claude Opus 4.5 <[email protected]>
468c363 to
b3209db
Compare
8541e4c to
72a3ea7
Compare
671ad5c to
5d3aec8
Compare
Co-Authored-By: Claude Opus 4.5 <[email protected]>
5d3aec8 to
1c03464
Compare
- Renamed properties: Auth.signIn/signUp -> Auth.currentSignIn/currentSignUp - MFA methods: sendMfaCode builder -> sendMfaPhoneCode/sendMfaEmailCode - signInWithIdToken: now uses builder pattern Co-Authored-By: Claude Opus 4.5 <[email protected]>
9c4d381 to
782f577
Compare
782f577 to
9c4d381
Compare
- Add template: wide
- Organize into Get started, Explore by feature, Prebuilt views, Resources sections
- Use Cards with level={2} for consistent styling
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Depends on https://github.com/clerk/clerk/pull/2018.
Previews
What does this solve?
ManifestHeadingtypeWhat changed?
ManifestHeadingtype to support section headings with SDK scoping