-
Notifications
You must be signed in to change notification settings - Fork 4
src/clyso/ceph/ai/rgw: added rgw subcommands for otto #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a6fdbc3 to
331ed88
Compare
|
just pasting the cli changes |
JoshuaGabriel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test
|
sorry for the multiple reviews, I was testing some pr review tool |
|
the CLI command looks good overall, haven't had a chance to actually test the commands. It would be nice if you tested this out yourself already if we can get some example outputs under docs/, or we can do this together when we get a rgw cluster. also would be nice to get some tests but not sure what that would look like, maybe some of the json output then pipe it into the commands? |
|
@JoshuaGabriel I do have a rgw cluster on my work proxmox, I can try testing this out. Should I add tests in this PR or create a separate one after this is merged? |
add it to this one |
0724bb3 to
bc6d5b5
Compare
|
looks good, could you add some basic tests or some short docs on how to use it |
|
yes will add those too |
No description provided.