Fix EGL GLX simultanous configuration #569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tritao
reviewed
Jun 9, 2025
tritao
reviewed
Jun 9, 2025
Contributor
Author
|
@VolkerEnderlein, I think we can merge this PR and #550. A new Coin release not too long after merging would be nice. |
Contributor
Seems like this is still failing for Windows, you probably need to guard it conditionally with CMake checks. |
Member
|
The failing test for Windows is caused by changes in handling Boost by CMake. I tried to fix this but did not commit it. Am 13.06.2025 19:59 schrieb João Matos ***@***.***>:tritao left a comment (coin3d/coin#569)
@VolkerEnderlein, I think we can merge this PR and #550. A new Coin release not too long after merging would be nice.
Seems like this is still failing for Windows, you probably need to guard it conditionally with CMake checks.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Member
Member
|
All platforms have been built successful but 32bit failed for some obscure reasons on MSYS2. The issue is on the CI side not in your code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes sure
HAVE_GLXis set whenCOIN_BUILD_GLXandCOIN_BUILD_EGLare set. Also setCOIN_BUILD_EGLto on by default. This should be safe because EGL is not used whenCOIN_BUILD_GLXis also set so by default it will not be used but it will be built.Should probably also check for
COIN_USE_EGLeverywhereHAVE_EGLis used. -> done