Thanks to visit codestin.com
Credit goes to Github.com

Skip to content

OCPBUGS-65706: [1.34] Fix Exec CPU affinity doesn't work when CPU load balancing is disabled. #9681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bitoku wants to merge 1 commit into
base: release-1.34
Choose a base branch
from
Open

OCPBUGS-65706: [1.34] Fix Exec CPU affinity doesn't work when CPU load balancing is disabled. #9681

bitoku wants to merge 1 commit into from

Conversation

@bitoku
Copy link
Contributor

@bitoku bitoku commented Dec 22, 2025

(cherry picked #9647)

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix Exec CPU affinity doesn't work when CPU load balancing is disabled.

@bitoku bitoku requested a review from mrunalp as a code owner December 22, 2025 12:41
@openshift-ci openshift-ci bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 22, 2025
@coderabbitai
Copy link

coderabbitai bot commented Dec 22, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. labels Dec 22, 2025
@openshift-ci openshift-ci bot requested review from QiWang19 and klihub December 22, 2025 12:42
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bitoku
Once this PR has been reviewed and has the lgtm label, please assign saschagrunert for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bitoku bitoku force-pushed the release-1.34-exec-cpu-affinity branch from 34e4d7b to c74f29a Compare December 22, 2025 12:43
@bitoku
Cherry-pick exec-cpu-affinity fix cri-o#9647
769628b 
- Delegate setting shared CPUs in cgroup to container runtime.

- Refactor cgroup manager logic: centralize `LibctrManager` and `CrunContainerCgroupManager` in `cgmgr` while replacing duplicates.

- Add exec cgroup for exec CPU affinity

- Refactor cgroup manager integration: centralize pod and container cgroup manager retrieval logic with `GetPodAndContainerCgroupManagers` and standardize function naming for consistency.

Signed-off-by: Ayato Tokubi <[email protected]>
@bitoku bitoku force-pushed the release-1.34-exec-cpu-affinity branch from c74f29a to 769628b Compare December 22, 2025 12:58
@bitoku bitoku changed the title [1.34] Fix Exec CPU affinity doesn't work when CPU load balancing is disabled. OCPBUGS-65706: [1.34] Fix Exec CPU affinity doesn't work when CPU load balancing is disabled. Dec 22, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 22, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 22, 2025

@bitoku: This pull request references Jira Issue OCPBUGS-65706, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-67014 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

(cherry picked #9647)

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix Exec CPU affinity doesn't work when CPU load balancing is disabled.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bitoku
Copy link
Contributor Author

bitoku commented Dec 22, 2025

@cri-o/cri-o-maintainers PTAL

@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

❌ Patch coverage is 44.04332% with 155 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.45%. Comparing base (babcd43) to head (769628b).

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.34    #9681      +/-   ##
================================================
+ Coverage         55.58%   64.45%   +8.87%     
================================================
  Files               202      202              
  Lines             28229    28375     +146     
================================================
+ Hits              15690    18290    +2600     
+ Misses            10975     8467    -2508     
- Partials           1564     1618      +54
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@QiWang19 QiWang19 Awaiting requested review from QiWang19

Assignees

No one assigned

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bitoku @openshift-ci-robot