Added Support for Hardlinks #306
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Store File/Dir Metadata (everything retrieved by `stat()`) in the respective FsBlobs (previously : stored in parent directory) - Adapted all Filesystem operations to this new format and adapted all test cases. - Added locking in the `FsBlobView` class for all operations that update the metadata - Implemented `link()` to create hardlinks and adapted `unlink()` to the concept of hardlinks. - For directories, the number of `nlinks` is the number of children + 2 (for `.` and `..`) as usual in POSIX. - Added / extended test cases for the correct creation/deletion of hard links. - Updated the implementation of `rename` : we are only allowed to rename a `dir` to another existing directory`s name if that target directory is empty. - Several refactorings: Removed now unused functions and added suggestions from ClangTidy. - TODO: Thorough self and external review + possibly More test cases - Implement relatime / noatime - Do we need an "atomic" rename, that first increases the link count by one, then does the rename and then decreases it again? This would require a `link()` and `unlink()` without updating access times.
808ac6e to
a88ac87
Compare
# Conflicts: # src/cryfs/impl/filesystem/CryDir.cpp # src/fspp/fs_interface/Dir.h # src/fspp/fstest/FsppDirTest.h # src/fspp/fstest/FsppNodeTest_Rename.h # test/fspp/fuse/readDir/testutils/FuseReadDirTest.cpp # test/fspp/testutils/FuseTest.h
…e inheritance structure
Member
|
Cool, thanks for implementing this. Let me know when you think this is ready for review, I can take a look then. Note that there have been some changes in the develop branch since you created this PR and they probably affect you.
|
Member
|
Are you still working on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Store File/Dir Metadata (everything retrieved by
stat()) in the respective FsBlobs (previously : stored in parent directory)Adapted all Filesystem operations to this new format and adapted all test cases.
Added locking in the
FsBlobViewclass for all operations that update the metadataImplemented
link()to create hardlinks and adaptedunlink()to the concept of hardlinks.For directories, the number of
nlinksis the number of children + 2 (for.and..) as usual in POSIX.Added / extended test cases for the correct creation/deletion of hard links.
Updated the implementation of
rename: we are only allowed to rename adirto another existing directory`s name if that target directory is empty.Several refactorings: Removed now unused functions and added suggestions from ClangTidy.
TODO: Thorough self and external review + possibly More test cases
Implement relatime / noatime
Do we need an "atomic" rename, that first increases the link count by one, then does the rename and then decreases it again? This would require a
link()andunlink()without updating access times.