fix(Mac): horizontal scrolling when shift key is held#689
fix(Mac): horizontal scrolling when shift key is held#689KKishikawa wants to merge 1 commit intodbgate:masterfrom
Conversation
e3c5b61 to
3c94bd4
Compare
|
Sorry this is a little delayed, I want to test it before merging and I need to do some setup first before I am able to test it on macOS. I have not forgotten about it! |
|
Hi, I finally had a macOS setup to test on. Whilst holding shift and scrolling down (without) this patch it worked like it should. Is the issue only related to mice? On touchpad it worked fine whilst using shift. |
|
@ProjectInfinity The basis of this problem is to provide a way to scroll horizontally, since a typical mouse can only scroll vertically. I have created a simple REPL that can confirm the "swapping". I tested mouse scrolling in a windows environment and a Mac environment. Windows 11 (23H2) Pro x64 mouse wheel macOS Sonoma 14.3.1 (Apple M3 Pro) mouse wheel touchpad (without shift key) scroll_normal.movtouchpad (with shift key) scroll_shift.mov |
Fixes #686
Description
When scrolling vertically while holding down the Shift key, the vertical scroll volume was converted to a horizontal scroll volume.
Since this process is handled at a higher level on MacOS, I fixed the problem so that no re-conversion is done.