fix: add visually hidden DialogTitle for accessibility #395
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #393
This PR adds a visually hidden
DialogTitleto theCommand.Dialogcomponent to satisfy Radix UI's accessibility requirements.Problem
The
Command.Dialogcomponent uses@radix-ui/react-dialoginternally but doesn't include aDialogTitle, which causes accessibility warnings in React 18+ and testing environments:Solution
Added a single line with a visually hidden
DialogTitlethat uses thelabelprop (with a fallback to "Command Menu"):Benefits
labelpropsrOnlyStylesconstant already in the codebaseTesting
Developers can now remove workarounds like: