Test suite #528
Open
Test suite #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive testing plan
Implement test plan phase 1
Implement test plan phase 1
Implement test plan phase 2
Implement test plan phase 3
Implement Test Plan Phase 4
Implement Test Plan Phase 4
Add Python 3.2 env to tox and CI
Implement Test Plan Phase 6
There was a problem hiding this comment.
Pull Request Overview
Adds a full pytest-based test suite, updates test tooling/config to use pytest, and adds support for Python 3.2.
- Introduce modularized tests under
tests/and a test helper intests/util.py - Update
tox.ini,setup.py,.travis.yml, andpytest.inito add Python 3.2 and switch topytest - Enhance
conftest.pyfor custom.docopttest collection and include a Test-Plan document
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tox.ini | Add py32 to envlist, skip_missing_interpreters, switch to pytest |
| setup.py | Add “Programming Language :: Python :: 3.2” classifier |
| .travis.yml | Include Python 3.2 in CI matrix |
| pytest.ini | Configure pytest options (addopts = -ra) |
| conftest.py | Support both old/new pytest from_parent APIs for custom tests |
| tests/util.py | Add run_docopt helper for invoking docopt in tests |
| tests/test_*.py | Add comprehensive feature-focused test modules |
| doc/python-3.2.5/Test-Plan.md | New test-plan document detailing suite organization |
| README.rst | Update testing instructions and supported Python versions |
| doc = 'Usage: prog ' + 'ARG ' * 20 | ||
| argv = ' '.join('v{}'.format(i) for i in range(20)) | ||
| result = run_docopt(doc, argv) | ||
| assert all(result['ARG'][i] == 'v{}'.format(i) for i in range(20)) |
There was a problem hiding this comment.
[nitpick] Use a direct equality assertion (e.g. assert result['ARG'] == [f'v{i}' for i in range(20)]) for clearer failure messages.
Suggested change
| assert all(result['ARG'][i] == 'v{}'.format(i) for i in range(20)) | |
| assert result['ARG'] == [f'v{i}' for i in range(20)] |
Comment on lines
+32
to
+33
| for i in range(depth): | ||
| assert result['cmd{}'.format(i)] == (i == depth - 1) |
There was a problem hiding this comment.
[nitpick] Consider comparing the entire result dict against an expected dict (e.g. {f'cmd{i}': i == depth-1 for i in range(depth)}) to simplify and clarify the test.
Suggested change
| for i in range(depth): | |
| assert result['cmd{}'.format(i)] == (i == depth - 1) | |
| expected = {f'cmd{i}': i == depth - 1 for i in range(depth)} | |
| assert result == expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.