Thanks to visit codestin.com
Credit goes to Github.com

Skip to content

fix: capture promise exception at runtime and not only at the creation #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
et1975 merged 1 commit into from
Jul 14, 2025
Merged

fix: capture promise exception at runtime and not only at the creation #304

et1975 merged 1 commit into from
Jul 14, 2025

Conversation

@MangelMaxime
Copy link
Member

@MangelMaxime MangelMaxime commented Jul 13, 2025 •
edited
Loading

Fix #302

I tested with a local reproduction and we do need both the

  • try ... with => capture exception during promise creation

     let increment model =
     failwith "dwdw"
     promise {
         return model + 1
     }

  • .catch => capture exception during promise execution

     let increment model =
     promise {
         failwith "Error"
         return model + 1
     }

@et1975 et1975 merged commit d043bd8 into v4.x Jul 14, 2025
3 checks passed
@et1975 et1975 deleted the fix-cmd-either-fable-4 branch July 14, 2025 18:37
@et1975
Copy link
Member

et1975 commented Jul 14, 2025

Released as 4.4.0

@MangelMaxime
Copy link
Member Author

MangelMaxime commented Jul 14, 2025

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cmd.either broken when error happens

3 participants

@MangelMaxime @et1975