Merged
Conversation
* Allow org members to invite via username * Clean up tests * Adjust tests * Clean up some code * Fix tests * Fix users * Fix org count:
* Adjust rate limiting for inviting to org * Adjust test
* "Fix: Prevent blank comments with only markdown tags - Add validation to check if comment has readable content after markdown processing - Reject comments that only contain markdown formatting symbols (e.g., ** **, _ _, ~~ ~~) - Add error message: 'cannot be empty. Please enter some text before submitting.' - Add comprehensive test coverage for various markdown-only scenarios Fixes #22572" * Enhance comment validation to allow image-only submissions - Update body_has_content method to permit comments containing only images. - Modify error message for empty comments in French and Portuguese locales. - Add test case for valid image-only comments. This improves user experience by allowing image-only comments while maintaining content validation. * Apply suggestion from @benhalpern * Refine comment validation to enhance media content handling - Update body_has_content method to clarify the allowance of media-only comments. - Remove hr tag from media tags as it does not represent meaningful content. - Ensure proper stripping of HTML tags and unescaping of entities for accurate text content validation. This change improves the clarity and functionality of comment validation while maintaining user experience. --------- Co-authored-by: Ben Halpern <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )