-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add com.browseros.BrowserOS #7354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: new-pr
Are you sure you want to change the base?
Conversation
Better to fix XML and getting the latest repo information
|
Thank you @metal3d for your help with creating flathub distrubtion! PS: I'm one of the maintainers of BrowserOS repo -- https://github.com/browseros-ai/BrowserOS |
|
This pull request is temporarily marked as blocked as some
|
|
I fixed the PR, how the bot will recheck? |
|
The domain to be used for verification is browseros.com. If you intend to verify this app, please confirm that you can upload https://browseros.com/.well-known/org.flathub.VerifiedApps.txt. Otherwise, ignore this. Please comment if this incorrect. |
|
I'm pretty sure that @shadowfax92 or @felarof99 can put the verification ID as soon as I can get the code in the developper portal. |
|
Starting a test build of the submission. Please fix any bot, build |
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
|
❌ Test build failed. Help
|
|
just upload the file for now so that i can tell you control the domain. code can come later |
| - type: file | ||
| url: https://github.com/browseros-ai/BrowserOS/releases/download/v0.33.0/BrowserOS_v0.33.0.1_x64.AppImage | ||
| sha256: 934e71bf99aa59f74a204e20e0cd3a788b40f2741c69770403caac9e1ca1b68d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is opensource it should be built from source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compiling a complete chromium distribution is way to high for GH Actions. How does Brave browser?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you know about our build infra that we don't?
If this is just Brave, then why are you submitting it? We don't take duplicate applications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hfiguiere it's not brave, it's a fork of chromium browser. The compile from source takes about 1 hr on a 24 core CPU.
So, can you please share how Brave does this today? since, they are another chromium fork browser, we can take inspiration from there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You just said you are not Brave. So how does this matter what Brave is doing?
bbhtt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
metainfo, desktop file, screenshots should be submitted upstream
|
@bbhtt I'm OK for desktop file and screnshots (I will remove them and leave authors to propose some files) but metainfo are specific to the flathub repository, isn't it? Or maybe I make a confusion with appdata.xml? On my other flathub repository it's not a problem |
|
https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines says to provide the metadata with the flathub repository, isn't it? |
@felarof99 or @shadowfax92 - can you please create this file ? |
This page definitely doesn't. |
No they are not. The appstream standard predate Flatpak. It even evolve on its own path.
It is. But two wrongs don't make a right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
screenshots do not belong here.
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "only-arches": ["x86_64"] | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is also very disappointing. But building from source should solve it.
| - type: file | ||
| url: https://github.com/browseros-ai/BrowserOS/releases/download/v0.33.0/BrowserOS_v0.33.0.1_x64.AppImage | ||
| sha256: 934e71bf99aa59f74a204e20e0cd3a788b40f2741c69770403caac9e1ca1b68d | ||
| finish-args: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finish-args should be above modules
| build-options: | ||
| env: | ||
| LD_LIBRARY_PATH: /app/lib:/usr/lib/x86_64-linux-gnu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| build-options: | |
| env: | |
| LD_LIBRARY_PATH: /app/lib:/usr/lib/x86_64-linux-gnu |
| sdk: org.freedesktop.Sdk | ||
| base: org.chromium.Chromium.BaseApp | ||
| command: browseros | ||
| base-version: "24.08" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of course this should match with the platform.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be (submitted and managed) upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be (submitted and managed) upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be (submitted and managed) upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is duplicated.
I updated our hosting to add a file at this location. Could you please test it now? https://browseros.com/.well-known/org.flathub.VerifiedApps.txt |
Please confirm your submission meets all the criteria
Capture.video.du.2025-12-20.01-00-41.mp4
If not, I contacted upstream developers about this submission. Link:
I'm not an upstream contributor, but I speak about this submission with the author @shadowfax92
Please add @shadowfax92 and @felarof99 as maintainer (main developers of BrowserOS)
Video of the built and installed flatpak on Fedora 43: