fix: preserve original role permissions during role replication (#34605) #35356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
When replicating a role,
get_all_perms()hides DocPerm entries when any Custom DocPerm exists for the same DocType (even for different roles). After replication, the new role gets Custom DocPerm entries, which causes the original role's DocPerm entries to be filtered out in the UI.Solution
When replicating, we now also create Custom DocPerm entries for the original role (if they don't already exist), ensuring its permissions remain visible after replication.
Test Plan
test_replicate_role_preserves_original_permissionsFixes #34605