Open
Conversation
PEP8 fixes for PR #2435 (glk0-reportgen) by autopep8
Member
|
@alexanderrichards Do you have any idea why the |
egede
reviewed
Sep 22, 2025
Member
egede
left a comment
There was a problem hiding this comment.
- Can you provide an example of how the
jsonoutput looks like. - There should be some test cases that shows that it is working (i.e the
deprecation_reportshould be tested. - The use of
deprecation_reportshould be integrated into the testing framework. So a test should be written that fails if there is code around which is past its expiry date.
01a15a3 to
e2a7683
Compare
e2a7683 to
0e5688e
Compare
Contributor
Author
Here's a prettified output: [
{
"name": "list_plugins",
"type": "function",
"file_path": "GangaCore/Runtime/GPIFunctions.py",
"lineno": 86,
"reason": "use plugins ('category')",
"deadline": "2025-12-31",
"last_version": "8.4.4"
},
{
"name": "applications",
"type": "function",
"file_path": "GangaCore/Runtime/GPIFunctions.py",
"lineno": 92,
"reason": "use plugins ('applications')",
"deadline": null,
"last_version": null
},
{
"name": "backends",
"type": "function",
"file_path": "GangaCore/Runtime/GPIFunctions.py",
"lineno": 97,
"reason": "use plugins ('backend')",
"deadline": null,
"last_version": null
}
]
Shows the functions to which we have applied the |
egede
reviewed
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the tooling to manage deprecations. It inclue utility functions that allow to locate all the deprecated classes and functions in the codebase, parse the relevant informations and output it as JSON, etc. It relies on the
@deprecateddecorator from PEP 702 and@deprecation_deadlinedecorator from GangaCore.Utility.Deprecation introduced in #2422 .