Open
Conversation
mesmith75
reviewed
Sep 20, 2025
| # The customisation of the interactive shell is done in this extension | ||
| cfg.InteractiveShellApp.extensions = ['GangaCore.Runtime.ganga_extension'] | ||
|
|
||
| IPython.start_ipython(argv=[], user_ns=local_ns, local_ns=local_ns, module=GangaCore.GPI, config=cfg) |
Contributor
There was a problem hiding this comment.
What is the purpose of this change?
Contributor
Author
There was a problem hiding this comment.
What is the purpose of this change?
The old call convention is deprecated.
Contributor
|
Is this all just linting? What is the script doing and when is it used? |
Contributor
Author
|
The script is for local lint & fix, during local testing. Added with removing some deprecated APIs used to produce noisy outputs when running Ganga. |
7acacaa to
056e8b0
Compare
Contributor
Author
|
I removed the linting part. Just the removal of various deprecated stuffs leading to some annoying messages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR collecting various contributions tangential to main work: local testing fixes, removing deprecated features, etc