Conversation
…sary comment in compose.yaml)
…on lib, pages, yaml files etc.
….com/gchq/Bailo into dev/rename-modelscan-to-artefactscan
PE39806
left a comment
There was a problem hiding this comment.
frontend/pages/docs/administration/microservices/file-scanners.mdx also could do with being updated (and maybe renamed to artefact scanners)
frontend/pages/docs/administration/microservices/artefact-scanners.mdx
Outdated
Show resolved
Hide resolved
| toolName: string = 'ModelScan' | ||
| export class ArtefactScanFileScanningConnector extends BaseQueueFileScanningConnector { | ||
| queue: PQueue = new PQueue({ concurrency: config.avScanning.artefactscan.concurrency }) | ||
| toolName: string = 'ArtefactScan' |
There was a problem hiding this comment.
This should be resolved with #3139, but this connector has some user facing functionality. When you have a result from ModelScan it shows as ArtifactScan was not able to find any threats which may be misleading.
| const artefactScanInfo = await getArtefactScanInfo() | ||
| this.version = artefactScanInfo.artefactscanVersion |
There was a problem hiding this comment.
This is a breaking change that means modelscan cannot connect with Bailo. It uses modelscanVersion for a health check.
Artefact scan returns the following response to ensure that it is healthy:
{
"apiName": "Bailo ArtefactScan API",
"apiVersion": "3.0.0",
"scannerName": "modelscan",
"modelscanVersion": "0.8.7"
}
|
Just a note there will be some conflicts if #3139 goes in first. Mostly code changes from filescanning to artefactScanning and path changes from .../filescanning/... to .../artefactScanning/... |
PE39806
left a comment
There was a problem hiding this comment.
Good to go. Make sure we flag the breaking changes (helm, GHCR etc.) when we next do a release
No description provided.