Add editable mirrored models to python#3227
Merged
Conversation
PE39806
requested changes
Feb 17, 2026
Contributor
|
It would also be good if you could update the tests. |
ON93754
reviewed
Feb 18, 2026
| res = self.client.get_model(model_id=self.id) | ||
| if "card" in res["model"]: | ||
| self._unpack_card(res["model"]["card"]) | ||
| logger.info("Latest card for ID %s successfully retrieved.", self.id) |
Member
There was a problem hiding this comment.
Is there a reason for not using the f-style style like the one below? Probably best if we just use f-strings everywhere for consistency
Member
Author
There was a problem hiding this comment.
https://docs.python.org/3/howto/logging.html#logging-variable-data It's simply for backwards compatibility. Since logging predates str.format() in Python 3.6. Although it's likely unnecessary in this case.
ON93754
reviewed
Feb 18, 2026
| else: | ||
| warnings.warn(f"ID {self.id} does not have any associated additional information.") | ||
|
|
||
| def _unpack_card(self, res, mirrored=False): |
Member
There was a problem hiding this comment.
Worth adding the return type
def _unpack_card(self, res, mirrored=False) -> None:
PE39806
previously approved these changes
Feb 18, 2026
ARADDCC002
previously approved these changes
Feb 18, 2026
PE39806
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.