Thanks to visit codestin.com
Credit goes to Github.com

Skip to content

xdiff: Remove invalid/no-op range checks in histogram diff #2122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ychin wants to merge 1 commit into
base: master
Choose a base branch
from
+0 −8
Open

xdiff: Remove invalid/no-op range checks in histogram diff #2122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions xdiff/xhistogram.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,6 @@

#include "xinclude.h"

#define MAX_PTR UINT_MAX
#define MAX_CNT UINT_MAX

#define LINE_END(n) (line##n + count##n - 1)
#define LINE_END_PTR(n) (*line##n + *count##n - 1)

Expand Down Expand Up @@ -121,8 +118,6 @@ static int scanA(struct histindex *index, int line1, int count1)
*/
NEXT_PTR(index, ptr) = rec->ptr;
rec->ptr = ptr;
/* cap rec->cnt at MAX_CNT */
rec->cnt = XDL_MIN(MAX_CNT, rec->cnt + 1);
LINE_MAP(index, ptr) = rec;
goto continue_scan;
}
Expand Down Expand Up @@ -313,9 +308,6 @@ static int histogram_diff(xpparam_t const *xpp, xdfenv_t *env,
if (count1 <= 0 && count2 <= 0)
return 0;

if ((unsigned int)LINE_END(1) >= MAX_PTR)
return -1;

if (!count1) {
while(count2--)
env->xdf2.changed[line2++ - 1] = true;
Expand Down
Loading