fix!: Change PremiumRequestUsageItem quantities to float64#4002
Merged
gmlewis merged 2 commits intogoogle:masterfrom Feb 13, 2026
Merged
fix!: Change PremiumRequestUsageItem quantities to float64#4002gmlewis merged 2 commits intogoogle:masterfrom
PremiumRequestUsageItem quantities to float64#4002gmlewis merged 2 commits intogoogle:masterfrom
Conversation
The GitHub API returns float values (e.g. 5054.0) for GrossQuantity, DiscountQuantity, and NetQuantity. Previously these were typed as int, causing JSON unmarshal errors. Fixes google#3996
PremiumRequestUsageItem quantities to float64
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4002 +/- ##
=======================================
Coverage 93.52% 93.52%
=======================================
Files 207 207
Lines 17597 17597
=======================================
Hits 16458 16458
Misses 938 938
Partials 201 201 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
approved these changes
Feb 12, 2026
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @kyyril!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
cc: @stevehipwell - @alexandear - @zyfy29 - @Not-Dhananjay-Mishra
Collaborator
|
Thank you, @Not-Dhananjay-Mishra! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
PremiumRequestUsageItemnumeric fields are nowfloat64.The GitHub API returns float values (e.g. 5054.0) for GrossQuantity, DiscountQuantity, and NetQuantity. Previously these were typed as int, causing JSON unmarshal errors.
Fixes #3996