-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: Add support for Codespace Machines APIs #3890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for Codespace Machines APIs #3890
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3890 +/- ##
==========================================
+ Coverage 92.53% 92.54% +0.01%
==========================================
Files 200 201 +1
Lines 14709 14732 +23
==========================================
+ Hits 13611 13634 +23
Misses 897 897
Partials 201 201 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Not-Dhananjay-Mishra!
Just a few tweaks, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.
cc: @stevehipwell - @alexandear - @zyfy29
|
@gmlewis Thanks for suggestions! I’ve made the changes. |
gmlewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Not-Dhananjay-Mishra and @alexandear!
LGTM.
Merging.
Relates: #2362
This PR adds support for endpoint of Codespace Machines