Thanks to visit codestin.com
Credit goes to Github.com

Skip to content

Conversation

@yosefbennywidyo
Copy link
Contributor

related to: #662 and #1249

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new sample ignore file for testing purposes. The patterns included are generally well-suited for testing various ignore rules. I have provided a couple of suggestions to improve some of the patterns to better align with common best practices for .gitignore files, which will make them more robust and explicit. These changes involve adding trailing slashes to directory patterns and adjusting a pattern to ensure an entire directory's contents are ignored recursively.

Comment on lines +2 to +3
/dist
/build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For clarity and to ensure only directories are matched, it's a good practice to add a trailing slash to directory patterns. This prevents accidentally ignoring a file that might have the same name as the directory. For example, mydir/ matches the directory mydir but not a file named mydir, whereas mydir would match both.

/dist/
/build/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant