feat: Include waved binary in Conda distributions #2266#2303
Open
marek-mihok wants to merge 14 commits intomainfrom
Open
feat: Include waved binary in Conda distributions #2266#2303marek-mihok wants to merge 14 commits intomainfrom
marek-mihok wants to merge 14 commits intomainfrom
Conversation
…n version separately
Contributor
Author
|
@mturoci I didn't have a chance to test new gh workflows so there is a possibility of failure, however I've tried to prepare everything for it to pass on the first try. |
mturoci
reviewed
Mar 28, 2024
Collaborator
mturoci
left a comment
There was a problem hiding this comment.
Thanks @marek-mihok! Looks great. A few questions.
| @@ -1,3 +1,19 @@ | |||
| build_conda_package = \ | |||
Collaborator
There was a problem hiding this comment.
Is it possible to create 2 separate make targets (conda-noarch and conda-arch) instead? And maybe a 3rd one for moving stuff around (the last section of the function)
| if not platform: | ||
| # Create a default metadata file in case of noarch builds. | ||
| create_metadata_file('linux', 'amd64') | ||
| # If conda build, copy binaries into package. |
Collaborator
There was a problem hiding this comment.
I though conda has its own build pipeline and doesn't use hatch. How does this work?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR fulfills these requirements: (check all the apply)
mainbranch.feat: Add a button #xxx, where "xxx" is the issue number).Closes #xxx, where "xxx" is the issue number.uifolder, unit tests (make test) still pass.Waved binaries are now included inside conda packages! 🎉
As of today building of platform-specific packages supporting multiple python versions is not supported by Conda, so we need to build packages for each python version individually and we end up with 21 packages total (4 architectures * 5 python versions + 1 noarch package without waved binary):
This PR also features a new gh action which only uploads already built packages into Anaconda cloud.
Closes #2266