Add async_remove_config_entry_device function #4690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a new function to remove HACS config entries from devices, with validation and error handling, addressing issue #4600.
- Imported
HomeAssistantErrorandDeviceEntryto support new removal logic. - Switched legacy comment markers from
##to#for consistency. - Implemented
async_remove_config_entry_deviceto validate identifiers and prevent removal of core or downloaded repositories.
Comments suppressed due to low confidence (2)
custom_components/hacs/init.py:249
- [nitpick] The error message refers to "service", but this function is removing config entries from devices. Consider rephrasing to "Cannot remove config entry from device {device_entry.id}, no valid HACS repository identifier found." for clarity.
f"Cannot remove service {device_entry.id}, no valid HACS repository identifier found."
custom_components/hacs/init.py:234
- This new function has multiple conditional branches and currently lacks tests. Please add unit tests covering cases such as missing identifiers, system ID checks, downloaded repositories, and successful removal.
async def async_remove_config_entry_device(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4600