Refactor tree retrieval to use a non deprecated method #4899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the repository tree fetching mechanism to use a direct API call instead of the legacy repository object method, introducing a LegacyTreeFile compatibility layer to maintain the expected tree structure interface.
- Introduces
LegacyTreeFileclass as a compatibility wrapper aroundGitHubGitTreeEntryModel - Refactors
get_tree()to directly call the GitHub API instead of usingrepository_object.get_tree() - Updates exception handling from
AIOGitHubAPIExceptiontoGitHubException
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| custom_components/hacs/utils/workarounds.py | Adds LegacyTreeFile class to wrap GitHub tree entry models with backward-compatible attributes |
| custom_components/hacs/repositories/base.py | Refactors get_tree() method to use direct API call and wraps results in LegacyTreeFile objects |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The entire repository_object is deprecated in aiogithubapi; this is a small step in getting rid of it.
LegacyTreeFile has been added as a compatibility layer, as significant refactoring is needed to eliminate outdated assumptions.