refactoring: use the arguments package for taint commands#38166
Closed
DanielMSchmidt wants to merge 3 commits intomainfrom
Closed
refactoring: use the arguments package for taint commands#38166DanielMSchmidt wants to merge 3 commits intomainfrom
DanielMSchmidt wants to merge 3 commits intomainfrom
Conversation
dbanck
previously approved these changes
Feb 16, 2026
Member
dbanck
left a comment
There was a problem hiding this comment.
LGTM!
I don't think we need the two StateLock values, as the default-value behaviour should already account for that. Having a value in the struct and in the argument parsing might cause confusion in future updates.
dbanck
previously approved these changes
Feb 16, 2026
f72ff00 to
0f3b8a2
Compare
0f3b8a2 to
40d6401
Compare
3 tasks
Member
|
Resolved by #38186 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Target Release
1.15.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry