add depends_on in order to automatically await these services start on "docker-compose up"#359
add depends_on in order to automatically await these services start on "docker-compose up"#359piradata wants to merge 1 commit intojudge0:masterfrom
Conversation
…n "docker-compose up"
piradata
left a comment
There was a problem hiding this comment.
add depends_on in order to automatically await these services start on "docker-compose up"
|
Look good to me! It looks like @hermanzdosilovic wrote that part because he intends for the rest of the containers to start after the Redis is fully booted, but if the first `docker-compose up -d' starts, it will take time to download the container from the Docker Hub, so if you use depends_on, you don't need to delay the service execution speed. |
|
yes, and them we could change this part on the changelog: to be a simple also, the deployment steps for a local intallation could be moved to |
|
Agree with you. We can still find it in Line 50 in README.md, Line 50 in 5a1ba5f |
|
@ryankwondev its almost 2 years now, how is it? only remember about that cause got a message about a merge conflict |
|
hello @ryankwondev ? |
No description provided.