Fix handling of exceptions thrown by frame handlers#201
Merged
WyriHaximus merged 1 commit intojakubkulhan:0.6.xfrom Jan 14, 2026
Merged
Fix handling of exceptions thrown by frame handlers#201WyriHaximus merged 1 commit intojakubkulhan:0.6.xfrom
WyriHaximus merged 1 commit intojakubkulhan:0.6.xfrom
Conversation
4ca0c90 to
f13b6b6
Compare
f13b6b6 to
ecb53c1
Compare
d46e3fe to
f0d5e98
Compare
f0d5e98 to
a3c0c52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, in the
connection->on('data')callback, if the function stored in$frameHandler['filter']throws an exception, it is not catched at all, causing the entire process to crash.I propose to catch these exceptions and reject the corresponding promise with it. This way, the exception is passed to the user calling original method like
channel->publish()allowing for proper error handling.