fix legacy syntax for gcc-15 compatibility #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
op3
reviewed
Nov 23, 2025
| int32_t idx = (((uint32_t)level * mat->lines) + (uint32_t)line) * mat->columns + (uint32_t)col; | ||
|
|
||
| memcpy(buffer, dblp + idx, num * sizeof(double)); | ||
| memcpy((int32_t *)buffer, dblp + idx, (uint32_t)num * sizeof(double)); |
Collaborator
There was a problem hiding this comment.
Not introduced in this PR, but this is an obvious type mismatch. Why are we using sizeof(double) to copy data to a (supposedly?) int32_t buffer?
I think this might accidentally work, as long as this is actually a (double*) buffer? At least, the call chain is
mgetdbl → mgetf8f = txt_get, and as far as I can tell, mgetdbl always gets passed a (double*) buffer (as the function name suggests).
So, we have to cast to (double *)buffer here.
op3
reviewed
Nov 23, 2025
| int32_t idx = (((uint32_t)level * mat->lines) + (uint32_t)line) * mat->columns + (uint32_t)col; | ||
|
|
||
| memcpy(dblp + idx, buffer, num * sizeof(double)); | ||
| memcpy(dblp + idx, (int32_t *)buffer, (uint32_t)num * sizeof(double)); |
Collaborator
There was a problem hiding this comment.
This should also be a (double *)buffer cast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed hdtv would install correctly but failed to compile the binaries it builds against the user's ROOT and Python installations at first launch. After some digging I found that this was because of gcc-15 dropping support for some legacy syntax found in the mfile source code. After making the proposed updates hdtv compiles and appears to work. Definitely check this over beforehand as this was a quick-and-dirty patch by a not-so-experienced dev, I'm not sure what may break (if anything) as a result.
System Details: