Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where the message toolbar was not displayed for assistant messages that lacked text content (e.g., when streaming was cancelled before text generation, or when messages only contained tool calls or reasoning). The fix removes the text content check from the conditional rendering logic, allowing the toolbar to be shown for all assistant messages regardless of content type.
Changes:
- Simplified the conditional rendering of the message toolbar for assistant messages by removing the check that required text content with non-zero length
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Barecheck - Code coverage reportTotal: 24.57%Your code coverage diff: 0.00% ▴ Uncovered files and lines
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Issue when u cancel streaming and message does not contain message part type text, me just need conditional based message role assistant
Before
After fix
Fixes Issues
Self Checklist