Cache both hash forms for FString #9143
Open
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the long form of the FString was cached and returned by longHashCode, but that value is actually just an int and can also be returned by hashCode. We can also pre-allocate and cache the fixnum version of the hash so it does not have to be created each time it is used from Ruby. Found while working on performance optimizations for Puma in puma/puma#3838.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the long form of the FString was cached and returned by longHashCode, but that value is actually just an int and can also be returned by hashCode. We can also pre-allocate and cache the fixnum version of the hash so it does not have to be created each time it is used from Ruby.
Found while working on performance optimizations for Puma in puma/puma#3838.