Assign document leading format to the first node instead#138
Merged
zkat merged 2 commits intokdl-org:mainfrom Sep 4, 2025
Merged
Assign document leading format to the first node instead#138zkat merged 2 commits intokdl-org:mainfrom
zkat merged 2 commits intokdl-org:mainfrom
Conversation
Author
|
I've now also tested it in my project and it seems to work like it should! |
zkat
approved these changes
Sep 3, 2025
Author
|
Hmmm, not sure about the dependencies. I didn't change any of them. |
Member
|
I'll just merge for now. This is MSRV bullshit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #136
This seems to work.
It did break a test, which I changed to make it work again.
So maybe assigning the leading space to the document was once considered correct?
This means that technically speaking this is a breaking change unless the leading space assigned to the doc is considered a 'bug' maybe.