-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Description
Description
Follow-up of #46462 just to add the comments dome in the PR #46465 (comment):
- Instead of logging errors, I prefer to add those detail messages to the event. We already already do that for OIDC in several places, and it allows those information to be shown in the events admin console where it is more accessible for people who have access to the UI, but not to the log file. This would then replace the logger.errorv(), and can be shorter as the event context AFAIK already contains the realm.
- It seems to me that the client is not set in the event context after it has been looked up.
- Probably events can also be checked in the test.
Reactions are currently unavailable