Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

Improve the events in the docker endpoint#46486

Merged
ahus1 merged 2 commits intokeycloak:mainfrom
rmartinc:issue-46469
Feb 20, 2026
Merged

Improve the events in the docker endpoint#46486
ahus1 merged 2 commits intokeycloak:mainfrom
rmartinc:issue-46469

Conversation

@rmartinc
Copy link
Contributor

Closes #46469

Little changes in the docker protocol to improve the events. The main difference is the test now checks the events. @ahus1 take a look to see if you see this OK (sometimes I have added the reason, sometimes not, following what I have seen in other endpoints).

@ahus1
Copy link
Member

ahus1 commented Feb 20, 2026

sometimes I have added the reason, sometimes not, following what I have seen in other endpoints

Thank you for the changes. The "how we do it in other places" might not be such a good guidance. Here some more thoughts:

  • An admin should be able to spot the cause of errors by using the Admin UI and the recorded events
  • The information and details we provide to the caller are sometimes redacted for security reasons, as we don't want to provide too much information that can be used as OSINT
  • The admin should receive the same information, and ideally enough information to make it actionable to fix the problem.

I've pushed one more change, please let me know your thoughts. I've added the same message returned to the caller in the details, although it might be redundant to the error code. I reduced the content that is already in the event in another place, and added details also to the InstantiationException.

Please let me know your thoughts.

Signed-off-by: Alexander Schwartz <[email protected]>
@rmartinc
Copy link
Contributor Author

@ahus1 LGTM! Then the idea is always adding the details instead of any logger. I tried to do the same that it was done in other parts. 😝

@ahus1 ahus1 self-assigned this Feb 20, 2026
@ahus1 ahus1 merged commit 59a7cec into keycloak:main Feb 20, 2026
90 of 92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve the events in the docker endpoint

2 participants