Improve the events in the docker endpoint#46486
Conversation
Closes keycloak#46469 Signed-off-by: rmartinc <[email protected]>
Thank you for the changes. The "how we do it in other places" might not be such a good guidance. Here some more thoughts:
I've pushed one more change, please let me know your thoughts. I've added the same message returned to the caller in the details, although it might be redundant to the error code. I reduced the content that is already in the event in another place, and added details also to the InstantiationException. Please let me know your thoughts. |
Signed-off-by: Alexander Schwartz <[email protected]>
|
@ahus1 LGTM! Then the idea is always adding the details instead of any logger. I tried to do the same that it was done in other parts. 😝 |
Closes #46469
Little changes in the docker protocol to improve the events. The main difference is the test now checks the events. @ahus1 take a look to see if you see this OK (sometimes I have added the reason, sometimes not, following what I have seen in other endpoints).