Admin API V2: allow to generate secret for clients with authentication method 'client-secret' #46257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabartos
reviewed
Feb 12, 2026
Contributor
mabartos
left a comment
There was a problem hiding this comment.
@michalvavrik Just a brief syntactic review for now.
rest/admin-v2/api/src/main/java/org/keycloak/models/mapper/RepModelMapper.java
Outdated
Show resolved
Hide resolved
rest/admin-v2/rest/src/main/java/org/keycloak/admin/api/client/DefaultClientApi.java
Show resolved
Hide resolved
Member
Author
|
Re CI failures: |
76a97dd to
07e5b9a
Compare
New behavior follows what is described in the linked issue. That is: - adds endpoint that supports generation of secret for authentication method 'client-secret' - if confidential client is created with method 'client-secret' without secret, we generate it and return it - if confidential client is updated (PUT) with method 'client-secret' without secret, we generate it - if confidential client is patched with method 'client-secret' without secret, we generate it - if confidential client with 'client-secret' auth method is patched without auth config, we keep the previous (existing) authentication configuration including the secret - if confidential client with 'client-secret' auth method is updated or patched with auth object that has method 'client-secret', we only generate the secret if it wasn't previously present on the client model Closes: keycloak#46136 Signed-off-by: Michal Vavřík <[email protected]>
07e5b9a to
6ce6e51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New behavior follows how I understand what is described in the linked issue. That is: