Executor for client uris pattern validation #46300
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26744fe to
db1b1b2
Compare
...c/main/java/org/keycloak/services/clientpolicy/executor/SecureClientUrisPatternExecutor.java
Dismissed
Show dismissed
Hide dismissed
Closes keycloak#45645 Signed-off-by: Giuseppe Graziano <[email protected]>
db1b1b2 to
610e198
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45645
Closes #45694
Instead of extending
SecureClientUrisExecutor, I introduced a new executor to provide fully configurable client URIs validation.I did not extend
SecureClientUrisExecutorbecause it already enforces HTTPS and disallows wildcards.There is a need to trust specific domains to mitigate SSRF on the JWKS URI (see discussion on #45645) and the same for bad
adminUrlvalues #45694 and changing the behavior ofSecureClientUrisExecutorwhile preserving backward compatibility would have been a bit forced.The new executor
SecureClientUrisPatternExecutorallows configuring:A list of allowed regex patterns.
A list of client URI field to which those patterns should be applied.
Configuration may be more complex, but it is very flexible to cover all the cases of validation of any uri field of the client.
Added dedicated tests and documentation.