Add tests that run with distribution placed in a directory with special characters #46301
Conversation
|
Looking at the |
mabartos
left a comment
There was a problem hiding this comment.
@michalvavrik LGTM, thanks!
@shawkins You want to review if it covers all scenarios as for the fix?
@michalvavrik The CI failures are unrelated, and the fix for them is already in the main branch, so you can just rebase.
quarkus/tests/integration/src/test/java/org/keycloak/it/cli/dist/AbstractPathDistTest.java
Outdated
Show resolved
Hide resolved
Adds tests for keycloak#45971 (fixed by keycloak#45972). Closes: keycloak#46135 Signed-off-by: Michal Vavřík <[email protected]>
90b24c7 to
26b0e27
Compare
vmuzikar
left a comment
There was a problem hiding this comment.
@michalvavrik Looks good, thank you. Alternative approach would've been running Quarkus tests in the CI from a different subdir with special characters but this works too.
| @BeforeStartDistribution(AddCustomScriptsProvider.class) | ||
| @RawDistOnly(reason = "Testing installation path handling") | ||
| @Test | ||
| @Launch(Build.NAME) |
There was a problem hiding this comment.
Just a nitpick. I think just testing start or start-dev would be enough as build is done implicitly. But we can keep as is.
Adds tests for #45971. I have run tests added in this PR after reverting the fix #45972 and they verify the issue.