Incorrect code used return value#46318
Merged
ahus1 merged 2 commits intokeycloak:mainfrom Feb 13, 2026
Merged
Conversation
Fixes keycloak#46290 Signed-off-by: Pedro Ruivo <[email protected]>
Signed-off-by: Alexander Schwartz <[email protected]>
ahus1
reviewed
Feb 13, 2026
Member
ahus1
left a comment
There was a problem hiding this comment.
Thank you for your PR with this workaround! One curious question below.
| if (data == null) { | ||
| return null; | ||
| } | ||
| return transaction.getCache().removeWithVersion(key, data.getVersion()) ? |
Member
There was a problem hiding this comment.
Curious: Does removeWithVersion() work nicely in a retry? What does a remove-with-version do if the entry doesn't exist on the primary owner?
Member
Author
There was a problem hiding this comment.
It does what we do for embedded
var e = cache.getEntry(k)
if (e.version == expectedVersion)
cache.remove(k, e.value)
ahus1
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46290