Make DynRankView test stronger and clarify comparisons#8751
Merged
crtrott merged 2 commits intokokkos:developfrom Jan 7, 2026
Merged
Make DynRankView test stronger and clarify comparisons#8751crtrott merged 2 commits intokokkos:developfrom
crtrott merged 2 commits intokokkos:developfrom
Conversation
Signed-off-by: Daniel Arndt <[email protected]>
Signed-off-by: Daniel Arndt <[email protected]>
ldh4
approved these changes
Dec 17, 2025
crtrott
approved these changes
Jan 7, 2026
janciesko
pushed a commit
to janciesko/kokkos
that referenced
this pull request
Jan 14, 2026
* Make DynRankView test stronger and clarify comparisons Signed-off-by: Daniel Arndt <[email protected]> * Avoid unused variable Signed-off-by: Daniel Arndt <[email protected]> --------- Signed-off-by: Daniel Arndt <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking at the MSVC+Cuda warnings in #8750, I noticed that the checks in
containers/unit_tests/TestDynRankView_LayoutMember.hppprobably aren't working as intended. This pull request makes it clear that only one value is allowed.