Merged
Conversation
Signed-off-by: Daniel Arndt <[email protected]>
Signed-off-by: Daniel Arndt <[email protected]>
tretre91
approved these changes
Jan 5, 2026
AdRi1t
reviewed
Jan 7, 2026
Signed-off-by: Daniel Arndt <[email protected]>
Signed-off-by: Daniel Arndt <[email protected]>
AdRi1t
approved these changes
Jan 7, 2026
Signed-off-by: Daniel Arndt <[email protected]>
tretre91
reviewed
Jan 7, 2026
tretre91
approved these changes
Jan 7, 2026
crtrott
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split-up from #8689.
ScatterValuewraps a reference and the current implementation only implements a move constructor out of all the special member functions. This move constructor behaves like a copy constructor. Thus, the moved from object still impacts the moved-to object which appears unintended. Instead, this pull request proposes to delete the copy constructor and copy assignment operator implying that the move constructor and move assignment operator are also implicitly deleted.We do some more cleanup by removing the (unused)
joinoperator as was already mentioned in a comment.Drive-by: Remove
ScatterAccess's default destructor.