[5.0.1] Revert mdspan with CUDA 12.9 workaround (#8779)#8782
Merged
dalg24 merged 1 commit intokokkos:release-candidate-5.0.1from Dec 29, 2025
Merged
[5.0.1] Revert mdspan with CUDA 12.9 workaround (#8779)#8782dalg24 merged 1 commit intokokkos:release-candidate-5.0.1from
dalg24 merged 1 commit intokokkos:release-candidate-5.0.1from
Conversation
Signed-off-by: Thomas Padioleau <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR reverts a CUDA 12.9-specific workaround for mdspan by cherry-picking changes from #8779. The changes remove compiler-version-specific logic and properly gate deprecated View types behind the KOKKOS_ENABLE_DEPRECATED_CODE_5 flag.
- Removes CUDA 12.9 workaround logic from cmake configuration
- Strengthens deprecation guards for legacy View type aliases
- Ensures consistent type alias behavior across deprecated and non-deprecated code paths
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cmake/kokkos_enable_options.cmake | Removes CUDA 12.9 compiler version check and simplifies VIEW_LEGACY_DEFAULT logic |
| core/src/View/Kokkos_ViewTraits.hpp | Adds KOKKOS_ENABLE_DEPRECATED_CODE_5 requirement to legacy data_type aliases |
| core/src/View/Kokkos_ViewLegacy.hpp | Conditionally uses scalar_array_type vs data_type based on deprecation flag |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JBludau
approved these changes
Dec 26, 2025
masterleinad
approved these changes
Dec 29, 2025
c216683
into
kokkos:release-candidate-5.0.1
51 of 62 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick #8779